fix(router-core): pathless nodes do not consume path segments during param extraction by Sheraff · Pull Request #6437 · TanStack/router

Sheraff · 2026-01-21T16:12:29Z

Summary by CodeRabbit

Tests
- Added coverage verifying parameter extraction in nested, pathless route layouts — ensures segments aren’t incorrectly consumed and parameters resolve to the deepest matching route.
Refactor
- Internal parameter-extraction state and indexing were reworked to support resumable extraction and clearer progression across nodes, improving reliability and maintainability.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

…param extraction

coderabbitai · 2026-01-21T16:12:56Z

Caution

Review failed

The head commit changed during the review from a8e27f7 to 60da609.

📝 Walkthrough

Walkthrough

Introduces a unified internal ParamExtractionState and refactors param extraction logic to be resumable, handle pathless and index nodes, and standardize indexing (partIndex/nodeIndex/pathIndex) across the matching/extraction workflow. Tests add coverage for pathless param extraction behavior.

Changes

Cohort / File(s)	Summary
Core param extraction refactor `packages/router-core/src/new-process-route-tree.ts`	Adds exported internal `ParamExtractionState`, replaces inline extraction state with it, refactors `extractParams` to return/propagate state, handles pathless/index nodes, reindexes extraction to use `partIndex` and `nodeParts[partIndex]`, and updates `MatchStackFrame.extract` usage.
Test coverage `packages/router-core/tests/new-process-route-tree.test.ts`	Adds a test verifying pathless nested layout nodes do not consume path segments during param extraction and that `rawParams` map correctly across segments.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

refactor(router-core): index routes have index nodes in the segment tree #6171 — Modifies new-process-route-tree.ts and param extraction semantics, including index node handling.
feat(router-core): validate params while matching #5936 — Touches the same extraction pipeline and extractParams resumability/state changes.
refactor(router-core): index nodes can skip the stack loop, they cannot have children #6173 — Related edits to matching stack/frame progression and index-node extraction behavior.

Suggested reviewers

schiller-manuel
nlynzaad

Poem

🐰 A little hop through parts and nodes,
I carry params down winding roads,
Pathless whispers I skip with care,
Indexes align — I bind each pair,
Hooray for states we now share! 🎉

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: fixing pathless nodes to not consume path segments during parameter extraction, which aligns with the core modifications in the extractParams function and test additions.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-01-21T16:13:08Z

View your CI Pipeline Execution ↗ for commit 60da609

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	✅ Succeeded	14m 50s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1m 43s	View ↗

☁️ Nx Cloud last updated this comment at 2026-01-21 17:30:35 UTC

pkg-pr-new · 2026-01-21T16:16:24Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@6437

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@6437

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@6437

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@6437

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@6437

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@6437

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@6437

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@6437

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@6437

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@6437

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@6437

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@6437

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@6437

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@6437

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@6437

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@6437

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@6437

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@6437

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@6437

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@6437

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@6437

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@6437

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@6437

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@6437

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@6437

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@6437

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-fn-stubs@6437

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@6437

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@6437

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@6437

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@6437

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@6437

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@6437

@tanstack/vue-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router@6437

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-devtools@6437

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-ssr-query@6437

@tanstack/vue-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start@6437

@tanstack/vue-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-client@6437

@tanstack/vue-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-server@6437

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@6437

commit: 60da609

…param extraction (TanStack#6437) * fix(router-core): pathless nodes do not consume path segments during param extraction * woops, didnt mean to commit this * better tests, and better solution * ci: apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

fix(router-core): pathless nodes do not consume path segments during …

64388c1

…param extraction

github-actions bot added the package: router-core label Jan 21, 2026

Sheraff and others added 3 commits January 21, 2026 17:16

woops, didnt mean to commit this

ec8b8bf

better tests, and better solution

a8e27f7

ci: apply automated fixes

60da609

Sheraff merged commit 0b2fcef into main Jan 21, 2026
5 checks passed

Sheraff deleted the fix-router-core-pathless-node-doesnt-consume-segment-during-param-extraction branch January 21, 2026 18:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(router-core): pathless nodes do not consume path segments during param extraction#6437

fix(router-core): pathless nodes do not consume path segments during param extraction#6437
Sheraff merged 4 commits intomainfrom
fix-router-core-pathless-node-doesnt-consume-segment-during-param-extraction

Sheraff commented Jan 21, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jan 21, 2026 •

edited

Loading

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

nx-cloud bot commented Jan 21, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Jan 21, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

Sheraff commented Jan 21, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

nx-cloud bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Sheraff commented Jan 21, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 21, 2026 •

edited

Loading

nx-cloud bot commented Jan 21, 2026 •

edited

Loading

pkg-pr-new bot commented Jan 21, 2026 •

edited

Loading